Allow formatting tags on a single line (different implementation) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a --single-line-tags option, which causes consecutive tags to be output on a single line. Also add a --multi-line-tags option to explicitly specify the current default behaviour of outputting one tag per line. When the --single-line-tags option is specified, tags separated by comments are merged into one line, as discussed in issue #22.
rayjolt
suggested changes
Jan 19, 2020
There was a problem hiding this comment.
I like this approach more than mine; specifying the location of the tag group and leaving it to sorted() to find out where the tag group line should go is cleaner than my approach of grouping tags and comments together. I have one suggestion about filtering Tags from __nodes in single-line-tag mode which I think will make the code a little clearer; I've left the comment inline.
# Conflicts: # reformat_gherkin/formatter.py
ducminh-phan
force-pushed
the
feature/single-line-tags
branch
from
0f2ce87
to
d5a4123
Compare
rayjolt
approved these changes
Jan 25, 2020
This was referenced Jan 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.