New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make jdbc-url and connection-uri optional #10
Comments
That sounds fine to me. |
Details in Issue 10 of the original repository [1] [1] duct-framework#10
Details in Issue 10 of the original repository [1] [1] duct-framework#10
A status update on this issue. We already have the implementation however we had a problem while writing the tests for our changes. Just let you know in advance here is the part that changed in order to accomplish what we described in this issue: Once we do the PR we'll give more details about the change in the commit message. What do you think? |
That seems fine, too. Thanks for your work on this. |
We just created the associatd PR: #15 |
As the README states:
Those HikariCP configuration options allow us to specify the connection details by supplying the individual options:
adapter
server-name
port-number
username
password
database-name
instead of a single
jdbc-url
orconnection-uri
. Butdatabase.sql.hikaricp
assumes that there will always be ajdbc-url
orconnection-uri
option provided. And unconditionally sets thejdbc-url
option in the map passed tohikari-cp/make-datasource
.Because
hikari-cp/make-datasource
checks the validity of thejdbc-url
option (and throws an exception if it doesn't like it), that means that even if we provide individual options that are valid and sufficient to create the datasource, we will still need to provide a fake (but still valid-looking)jdbc-url
orconnection-uri
. Even if that fakejdbc-url
/connection-uri
is completely ignored byhikari-cp/make-datasource
in this case.So we propose to make
jdbc-url
/connection-uri
completely optional. And we would be glad to provide a pull request for that change.The text was updated successfully, but these errors were encountered: