Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from signal to sigaction #7

Closed
OleStrohm opened this issue Aug 16, 2020 · 2 comments
Closed

Migrate from signal to sigaction #7

OleStrohm opened this issue Aug 16, 2020 · 2 comments

Comments

@OleStrohm
Copy link

According to the man page for signal(2) it's use is discouraged in favour of sigaction(2). Migration is very easy (Just make two sigactions, one for expire and for ignore. I've already tested this on my fork and it's quite easy. This is not crucial as signal(2) obviously works, but I think it's always good to try and use more up to date apis.

@dudik
Copy link
Owner

dudik commented Aug 18, 2020

This was a great suggestion. The transition took a little bit more time than I expected, but everything should now work properly. Again, I might have forgot to test some odd edge case, so any testing on your side is appreciated. Thanks.

@dudik dudik closed this as completed Aug 18, 2020
@OleStrohm
Copy link
Author

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants