Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pkg_resource with importlib.metadata #177

Merged
merged 1 commit into from Apr 13, 2021
Merged

Replace pkg_resource with importlib.metadata #177

merged 1 commit into from Apr 13, 2021

Conversation

jwodder
Copy link
Contributor

@jwodder jwodder commented Apr 13, 2021

This PR replaces the need to add setuptools as a runtime dependency in #175.

Changes

  • I ran tests locally and they passed

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 86.544% when pulling c292f32 on jwodder:importlib-metadata into a5cd404 on duecredit:master.

@yarikoptic
Copy link
Member

Thank you @jwodder !

@yarikoptic yarikoptic merged commit 076c56f into duecredit:master Apr 13, 2021
@yarikoptic yarikoptic mentioned this pull request Apr 13, 2021
Closed
2 tasks
@hroncok
Copy link

hroncok commented Apr 13, 2021

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jwodder @coveralls @yarikoptic @hroncok