Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This super simple PR allows programmers to more easily create (manage) pipeline specific .duecredit.p files / reports #193

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

marcelzwiers
Copy link
Contributor

This pull request makes the DUECREDIT_FILE config variable environment dependent but otherwise doesn't interfere with normal operation

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce62f67) 82.35% compared to head (02c6621) 82.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files          47       47           
  Lines        2420     2420           
  Branches      339      339           
=======================================
  Hits         1993     1993           
  Misses        356      356           
  Partials       71       71           
Flag Coverage Δ
unittests 82.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcelzwiers
Copy link
Contributor Author

In the long run, I think it would be better to add self.__duecredit_file=.. to the DueSwitch class

@yarikoptic yarikoptic merged commit 332142b into duecredit:master Nov 16, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants