-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add & apply pre-commit with black and isort #199
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 81.00% 80.79% -0.22%
==========================================
Files 47 47
Lines 2517 2515 -2
Branches 365 364 -1
==========================================
- Hits 2039 2032 -7
- Misses 383 388 +5
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi, I think we wants to merge everything .... but who goes in first ? |
@a-detiste Why are you asking? You don't appear to have write permission, so you wouldn't be the one merging anyway. |
(I'm not using an IDE so huge merge means pain...) |
@a-detiste Is the concern here about updating your PR after mine is merged? If yours is merged first, I will take care of the conflicts in mine. |
Yes. I'm down to 185 errors in |
since I rebased/merged that other PR, I will "rebase" this one by just taking the fd148c7 on top of current master and then reapplying... |
=== Do not change lines below === { "chain": [], "cmd": "pre-commit run --all || :", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
otherwise, after black reformatting into multiple lines we ended up pragma not applying to target filter()
ok, fixed it up and also added codespell. Let's proceed, thank you @jwodder ! |
Includes the commits from #197.