Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add & apply pre-commit with black and isort #199

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Add & apply pre-commit with black and isort #199

merged 5 commits into from
Nov 28, 2023

Conversation

jwodder
Copy link
Contributor

@jwodder jwodder commented Nov 23, 2023

Includes the commits from #197.

@jwodder jwodder changed the title Pre commit Add & apply pre-commit with black and isort Nov 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 135 lines in your changes are missing coverage. Please review.

Comparison is base (d832043) 81.00% compared to head (6861208) 80.79%.

Files Patch % Lines
duecredit/utils.py 30.55% 23 Missing and 2 partials ⚠️
duecredit/tests/test_api.py 56.52% 19 Missing and 1 partial ⚠️
duecredit/collector.py 67.44% 11 Missing and 3 partials ⚠️
duecredit/injections/injector.py 73.58% 11 Missing and 3 partials ⚠️
duecredit/io.py 80.28% 11 Missing and 3 partials ⚠️
duecredit/log.py 54.83% 11 Missing and 3 partials ⚠️
duecredit/__main__.py 46.66% 4 Missing and 4 partials ⚠️
duecredit/cmdline/helpers.py 50.00% 4 Missing and 3 partials ⚠️
duecredit/dueswitch.py 71.42% 3 Missing and 1 partial ⚠️
duecredit/cmdline/main.py 85.00% 0 Missing and 3 partials ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   81.00%   80.79%   -0.22%     
==========================================
  Files          47       47              
  Lines        2517     2515       -2     
  Branches      365      364       -1     
==========================================
- Hits         2039     2032       -7     
- Misses        383      388       +5     
  Partials       95       95              
Flag Coverage Δ
unittests 80.63% <82.69%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-detiste
Copy link
Contributor

Hi, I think we wants to merge everything .... but who goes in first ?

@jwodder
Copy link
Contributor Author

jwodder commented Nov 23, 2023

@a-detiste Why are you asking? You don't appear to have write permission, so you wouldn't be the one merging anyway.

@a-detiste
Copy link
Contributor

(I'm not using an IDE so huge merge means pain...)

@jwodder
Copy link
Contributor Author

jwodder commented Nov 23, 2023

@a-detiste Is the concern here about updating your PR after mine is merged? If yours is merged first, I will take care of the conflicts in mine.

@a-detiste
Copy link
Contributor

@a-detiste Is the concern here about updating your PR after mine is merged? If yours is merged first, I will take care of the conflicts in mine.

Yes.

I'm down to 185 errors in mypy --strict.
I will resume when your PR are merged.
Thanks for the good work.

@yarikoptic
Copy link
Member

since I rebased/merged that other PR, I will "rebase" this one by just taking the fd148c7 on top of current master and then reapplying...

jwodder and others added 5 commits November 28, 2023 09:13
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "pre-commit run --all || :",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
otherwise, after black reformatting into multiple lines we ended up pragma not
applying to target filter()
@yarikoptic
Copy link
Member

ok, fixed it up and also added codespell. Let's proceed, thank you @jwodder !

@yarikoptic yarikoptic merged commit b0e2674 into duecredit:master Nov 28, 2023
15 checks passed
@jwodder jwodder deleted the pre-commit branch November 28, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants