Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using distutils; test against Python 3.12 #207

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Stop using distutils; test against Python 3.12 #207

merged 2 commits into from
Dec 4, 2023

Conversation

jwodder
Copy link
Contributor

@jwodder jwodder commented Nov 28, 2023

No description provided.

@jwodder
Copy link
Contributor Author

jwodder commented Dec 4, 2023

@yarikoptic Ping.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (74458f8) 81.29% compared to head (2b43b23) 81.26%.

Files Patch % Lines
duecredit/io.py 25.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   81.29%   81.26%   -0.04%     
==========================================
  Files          47       47              
  Lines        2534     2535       +1     
  Branches      359      358       -1     
==========================================
  Hits         2060     2060              
- Misses        383      384       +1     
  Partials       91       91              
Flag Coverage Δ
unittests 81.14% <83.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

eh, probably my resolving of conflicts online didn't go cleanly. Could you please re-do it properly @jwodder ?

@jwodder
Copy link
Contributor Author

jwodder commented Dec 4, 2023

@yarikoptic It should be fixed now.

@yarikoptic
Copy link
Member

Thank you!

@yarikoptic yarikoptic merged commit ad40215 into duecredit:master Dec 4, 2023
18 checks passed
@a-detiste
Copy link
Contributor

bts subscribe 1014890 :-)

@jwodder jwodder deleted the no-distutils branch December 4, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants