Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more type annotations #209

Merged
merged 1 commit into from
Jan 7, 2024
Merged

add more type annotations #209

merged 1 commit into from
Jan 7, 2024

Conversation

a-detiste
Copy link
Contributor

So I continue adding type annotations, more commits will follow

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (ad40215) 81.26% compared to head (9eb7fee) 81.12%.

Files Patch % Lines
duecredit/tests/test_api.py 72.22% 4 Missing and 1 partial ⚠️
duecredit/tests/mod/submod.py 0.00% 3 Missing ⚠️
duecredit/utils.py 50.00% 3 Missing ⚠️
duecredit/tests/test_collector.py 93.93% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   81.26%   81.12%   -0.14%     
==========================================
  Files          47       47              
  Lines        2535     2559      +24     
  Branches      358      362       +4     
==========================================
+ Hits         2060     2076      +16     
- Misses        384      390       +6     
- Partials       91       93       +2     
Flag Coverage Δ
unittests 81.00% <81.15%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-detiste a-detiste merged commit 50a0706 into master Jan 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants