Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Don't use bare "except:" #52

Merged
merged 1 commit into from Aug 12, 2016
Merged

Don't use bare "except:" #52

merged 1 commit into from Aug 12, 2016

Conversation

jwilk
Copy link
Contributor

@jwilk jwilk commented Aug 10, 2016

The except: clause would catch all the exceptions, including KeyboardInterrupt.

@jwilk
Don't use bare "except:"
61d6d33 
The "except:" clause would catch all the exceptions, including
KeyboardInterrupt.
@coveralls
Copy link

coveralls commented Aug 10, 2016 •
edited

Coverage Status

Coverage remained the same at 23.392% when pulling 61d6d33 on jwilk:no-bare-except into 6c5aa06 on duggan:master.

@duggan
Copy link
Owner

duggan commented Aug 12, 2016

Sensible change, thanks.

@duggan duggan merged commit 2959807 into duggan:master Aug 12, 2016
@jwilk jwilk deleted the no-bare-except branch August 12, 2016 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwilk @coveralls @duggan