Skip to content

Commit

Permalink
test: Fix surround sound test case on Tizen (shaka-project#4893)
Browse files Browse the repository at this point in the history
This test started failing on Tizen after PR shaka-project#4858, which updates codecs
in manifest metadata any time they are rewritten. Since ac-3 is
rewritten as ec-3 on Tizen, that caused this test case covering ac-3 to
start failing (because the codec says ec-3 by the end of the test).
  • Loading branch information
joeyparrish committed Jan 13, 2023
1 parent b7b2a7c commit 3611f07
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions test/player_unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -3425,7 +3425,9 @@ describe('Player', () => {
variant.addAudio(0, (stream) => {
stream.channelsCount = 6;
stream.audioSamplingRate = 48000;
stream.codecs = 'ac-3';
// ac-3 is rewritten as ec-3 on Tizen, so for the stability of this
// test case, use ec-3.
stream.codecs = 'ec-3';
});
});

Expand All @@ -3450,7 +3452,7 @@ describe('Player', () => {
expect(abrManager.variants.length).toBe(1);
// It should be the 6-channel variant, based on our preference.
expect(abrManager.variants[0].audio.channelsCount).toBe(6);
expect(abrManager.variants[0].audio.codecs).toBe('ac-3');
expect(abrManager.variants[0].audio.codecs).toBe('ec-3');
});
});

Expand Down

0 comments on commit 3611f07

Please sign in to comment.