fix: cmcd not applying configuration changes (shaka-project#5119)

Co-authored-by: Dan Sparacio <daniel.sparacio@cbsinteractive.com>
duggaraju · Mar 23, 2023 · 58aa45f · 58aa45f
1 parent 93baba2
commit 58aa45f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/player.js b/lib/player.js
@@ -2886,8 +2886,7 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
     };
 
     return new shaka.net.NetworkingEngine(
-        onProgressUpdated_, onHeadersReceived_, onDownloadFailed_,
-        this.config_.cmcd.enabled ? onRequest_ : undefined);
+        onProgressUpdated_, onHeadersReceived_, onDownloadFailed_, onRequest_);
   }
 
   /**
@@ -3308,6 +3307,9 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
     if (this.adManager_) {
       this.adManager_.configure(this.config_.ads);
     }
+    if (this.cmcdManager_) {
+      this.cmcdManager_.configure(this.config_.cmcd);
+    }
   }
 
   /**

diff --git a/lib/util/cmcd_manager.js b/lib/util/cmcd_manager.js
@@ -57,6 +57,16 @@ shaka.util.CmcdManager = class {
     this.starved_ = false;
   }
 
+  /**
+   * Called by the Player to provide an updated configuration any time it
+   * changes.
+   *
+   * @param {shaka.extern.CmcdConfiguration} config
+   */
+  configure(config) {
+    this.config_ = config;
+  }
+
   /**
    * Set the buffering state
    *