Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strutil: HammingDistance func #197

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

donutloop
Copy link
Collaborator

The Hamming distance is the number of positions at which the corresponding symbols are different

The Hamming distance is the number of positions at which the corresponding symbols are different
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.76%. Comparing base (7a98c43) to head (c0575f7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   79.74%   79.76%   +0.02%     
==========================================
  Files          65       65              
  Lines        7424     7434      +10     
==========================================
+ Hits         5920     5930      +10     
  Misses       1136     1136              
  Partials      368      368              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donutloop
Copy link
Collaborator Author

@duke-git Please review. Do you believe we should merge this no breaking change into rc or main?


### <span id="HammingDistance">HammingDistance</span>

<p>TBD</p>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duke-git Please change this

@duke-git
Copy link
Owner

duke-git commented Mar 3, 2024

@duke-git Please review. Do you believe we should merge this no breaking change into rc or main?

@donutloop, yes, please merge this PR to rc branch. main branch is frozen, won't accept PR again.

@donutloop donutloop changed the base branch from main to rc March 3, 2024 05:49
@donutloop
Copy link
Collaborator Author

@duke-git Please review. Do you believe we should merge this no breaking change into rc or main?

@donutloop, yes, please merge this PR to rc branch. main branch is frozen, won't accept PR again.

@duke-git
Updated branch

@duke-git duke-git merged commit 0b5e884 into duke-git:rc Mar 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants