Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function: AcceptIf #198

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Function: AcceptIf #198

merged 1 commit into from
Mar 4, 2024

Conversation

donutloop
Copy link
Collaborator

@donutloop donutloop commented Mar 3, 2024

AcceptIf returns another function of the same signature as the apply function but also includes a bool value to indicate success or failure.
A predicate function that takes an argument of type T and returns a bool.
An apply function that also takes an argument of type T and returns a modified value of the same type.

@donutloop
Copy link
Collaborator Author

@duke-git Please review

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.99%. Comparing base (aabfcb7) to head (7f6ecad).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               rc     #198      +/-   ##
==========================================
+ Coverage   79.97%   79.99%   +0.02%     
==========================================
  Files          65       65              
  Lines        7494     7504      +10     
==========================================
+ Hits         5993     6003      +10     
  Misses       1135     1135              
  Partials      366      366              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donutloop donutloop force-pushed the feature/AcceptIf branch 3 times, most recently from 9133a3a to a9d43b5 Compare March 3, 2024 17:24
AcceptIf returns another function of the same signature as the apply function but also includes a bool value to indicate success or failure.
A predicate function that takes an argument of type T and returns a bool.
An apply function that also takes an argument of type T and returns a modified value of the same type.
@duke-git duke-git merged commit e138043 into duke-git:rc Mar 4, 2024
3 checks passed
@duke-git
Copy link
Owner

duke-git commented Mar 4, 2024

@donutloop,since we have added so many features to lancet recently, I plan to release v2.3.0 tomorrow (5th, March). Do you think there are still features that haven’t been merged yet?

@donutloop
Copy link
Collaborator Author

@donutloop,since we have added so many features to lancet recently, I plan to release v2.3.0 tomorrow (5th, March). Do you think there are still features that haven’t been merged yet?

@duke-git Before releasing it, we should include the missing parts of the document. I haven't added descriptions for all new changes yet.

@duke-git
Copy link
Owner

duke-git commented Mar 4, 2024

@donutloop,since we have added so many features to lancet recently, I plan to release v2.3.0 tomorrow (5th, March). Do you think there are still features that haven’t been merged yet?

@duke-git Before releasing it, we should include the missing parts of the document. I haven't added descriptions for all new changes yet.

@donutloop Sure. I updated all the documentation I could find. But it may not be complete. The latest branch is rc. After you add descriptions for all new changes, Then we can release v2.3.0

@duke-git
Copy link
Owner

duke-git commented Mar 5, 2024

@donutloop, I have updated the documentation. Will release v2.3.0. If some documentation is missing, we can add it after release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants