Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(slice): optimize function #211

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

cannian1
Copy link
Collaborator

@cannian1 cannian1 commented Apr 5, 2024

The Concat method and the Merge method serve essentially the same purpose, and in the slices package of Go 1.22, the same functionality is named Concat. Should one of them be deprecated?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 80.82%. Comparing base (e461acd) to head (ffd9d2e).

Files Patch % Lines
slice/slice.go 80.95% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               rc     #211      +/-   ##
==========================================
- Coverage   80.84%   80.82%   -0.02%     
==========================================
  Files          65       65              
  Lines        7602     7616      +14     
==========================================
+ Hits         6146     6156      +10     
- Misses       1078     1080       +2     
- Partials      378      380       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duke-git
Copy link
Owner

duke-git commented Apr 6, 2024

@cannian1, okay, In addition, I have added you to the list of lancet collaborators, working together to make lancet more powerful.

@duke-git duke-git merged commit 6853d62 into duke-git:rc Apr 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants