Merge pull request #220 from duke-libraries/roles-cleanup

Cleans up some detritus in the roles code
duke-libraries · Apr 22, 2015 · 64641a0 · 64641a0
2 parents 9e576b5 + ad8e8f6
commit 64641a0
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 39 deletions.
diff --git a/lib/ddr/auth/roles.rb b/lib/ddr/auth/roles.rb
@@ -8,13 +8,12 @@ module Roles
       autoload :RoleType
       autoload :RoleTypes
       autoload :Query      
-      autoload :Scopes
 
       include RoleTypes
 
       RESOURCE_SCOPE = "resource"
       POLICY_SCOPE = "policy"
-      SCOPES = [RESOURCE_SCOPE, POLICY_SCOPE]
+      SCOPES = [RESOURCE_SCOPE, POLICY_SCOPE].freeze
 
       class << self
         def type_map

diff --git a/lib/ddr/auth/roles/role.rb b/lib/ddr/auth/roles/role.rb
@@ -10,33 +10,6 @@ class Role < ActiveTriples::Resource
 
         DEFAULT_SCOPE = Roles::RESOURCE_SCOPE
 
-        # TYPES = {
-        #   "Curator" => {
-        #     permissions: [:read, :download, :add_children, :edit, :replace, :arrange, :grant].freeze
-        #     }.freeze,
-
-        #   "Editor" => {
-        #     permissions: [:read, :download, :add_children, :edit, :replace, :arrange].freeze
-        #     }.freeze,
-
-        #   "MetadataEditor" => {
-        #     permissions: [:read, :download, :edit].freeze
-        #     }.freeze,
-
-        #   "Contributor" => {
-        #     permissions: [:read, :add_children].freeze
-        #     }.freeze,
-
-        #   "Downloader" => {
-        #     permissions: [:read, :download].freeze
-        #     }.freeze,
-
-        #   "Viewer" => {
-        #     permissions: [:read].freeze
-        #     }.freeze
-
-        # }.freeze
-
         include RDF::Isomorphic
         include Hydra::Validations
 

diff --git a/lib/ddr/auth/roles/scopes.rb b/lib/ddr/auth/roles/scopes.rb
diff --git a/spec/models/ability_spec.rb → spec/auth/ability_spec.rb b/spec/models/ability_spec.rb → spec/auth/ability_spec.rb