This repository has been archived by the owner on Jun 27, 2020. It is now read-only.
Changes indexing strategy for identifiers. Closes #257. #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| identifier.each { |id| all_ids << id } | ||
| all_ids << local_id if local_id | ||
| all_ids << permanent_id if permanent_id | ||
| all_ids << pid if pid |
There was a problem hiding this comment.
If you want to make this more compact, try:
def all_identifiers
identifier + [local_id, permanent_id, pid].compact
endRemoves Ddr::IndexFields::IDENTIFIER. Adds Ddr::IndexFields::IDENTIFIER_ALL that includes dcterms:identifier, local_id, permanent_id, and pid.
coblej
force-pushed
the
257-identifier-indexing
branch
from
a5c1dac
to
e5c9067
Compare
dchandekstark
added a commit
that referenced
this pull request
Jun 23, 2015
Changes indexing strategy for identifiers. Closes #257.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Ddr::IndexFields::IDENTIFIER.
Adds Ddr::IndexFields::IDENTIFIER_ALL that includes dcterms:identifier, local_id, permanent_id, and pid.