Freezes string constants

Identifier#unavailable! patched to use += instead of << when adding reason Fixes #45
duke-libraries · Apr 23, 2015 · 9a218c9 · 9a218c9
1 parent fbd7553
commit 9a218c9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/lib/ezid/client.rb b/lib/ezid/client.rb
@@ -18,10 +18,10 @@ module Ezid
   class Client
 
     # ezid-client gem version (e.g., "0.8.0")
-    VERSION = File.read(File.expand_path("../../../VERSION", __FILE__)).chomp
+    VERSION = File.read(File.expand_path("../../../VERSION", __FILE__)).chomp.freeze
 
     # EZID API version
-    API_VERSION = "2"
+    API_VERSION = "2".freeze
 
     class << self
       # Configuration reader

diff --git a/lib/ezid/configuration.rb b/lib/ezid/configuration.rb
@@ -10,7 +10,7 @@ module Ezid
   #
   class Configuration
 
-    HOST = "ezid.cdlib.org"
+    HOST = "ezid.cdlib.org".freeze
     PORT = 443
     TIMEOUT = 300
 

diff --git a/lib/ezid/identifier.rb b/lib/ezid/identifier.rb
@@ -12,12 +12,12 @@ class Identifier
     private :state, :state=, :id=
 
     # Attributes to display on inspect
-    INSPECT_ATTRS = %w( id status target created )
+    INSPECT_ATTRS = %w( id status target created ).freeze
 
     # EZID status terms
-    PUBLIC = "public"
-    RESERVED = "reserved"
-    UNAVAILABLE = "unavailable"
+    PUBLIC = "public".freeze
+    RESERVED = "reserved".freeze
+    UNAVAILABLE = "unavailable".freeze
 
     class << self
       attr_accessor :defaults
@@ -170,7 +170,9 @@ def deletable?
     def unavailable!(reason = nil)
       raise Error, "Cannot make a reserved identifier unavailable." if persisted? && reserved?
       value = UNAVAILABLE
-      value << " | #{reason}" if reason
+      if reason
+        value += " | #{reason}"
+      end
       self.status = value
     end