perf: use binary search for faster array operations #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps a lot with dumbmatter#44
nolanlawson
changed the title
|
FWIW the project that piqued my interest in this issue is emoji-picker-element. Just tested loading the full emoji database for that project, and it's dropped from 13.5s to 430ms. Progress! 🙂 |
|
This is an awesome improvement. It speeds up the test suite by 20% too :) I'm going to merge this an do a new release soon. |
Krinkle
reviewed
Jul 3, 2020
| let mid; | ||
| while (low < high) { | ||
| // tslint:disable-next-line:no-bitwise | ||
| mid = (low + high) >>> 1; // like Math.floor((low + high) / 2) but fast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps a lot with #44
This implements a binary search for most of the
RecordStoreoperations -get(),add(),delete(). Using the benchmark mentioned in #44, running in Node v14 on Ubuntu on my XPS 13, I measured the following improvement (median of 3 iterations):There are still further improvements that can be made (mostly in
RecordStore.addin the value comparison), but I'm holding off since this PR is already big enough and 5.5x is already a pretty big improvement.I considered switching to a completely different backing store, but that seemed like it would have been a lot of work. This way we can keep the existing Array backing store and just optimize some of the lookups.