Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename React component files to .jsx #202

Closed
garyking opened this issue Aug 24, 2016 · 2 comments
Closed

Rename React component files to .jsx #202

garyking opened this issue Aug 24, 2016 · 2 comments

Comments

@garyking
Copy link
Contributor

Per React's docs suggesting that components end in .jsx, and so that GitHub's highlighting works properly. I'm sure you've seen the red lines like here, which won't happen if the files end in .jsx.

Explanation of the issue here.
@dumbmatter
Copy link
Member

I hadn't noticed, but that's not good. However, changing file extensions to work around a bug in GitHub does not really appeal to me.

@battaile
Copy link
Contributor

battaile commented Aug 24, 2016 •
edited

Fwiw, the shift has been away from jsx for reasons Abramov lays out here.

facebook/create-react-app#87 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@garyking @dumbmatter @battaile