Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0: Add a prop to disable automatic font size recalculation #30

Merged
merged 9 commits into from Mar 22, 2020

Conversation

dumptyd
Copy link
Owner

@dumptyd dumptyd commented Mar 18, 2020

This PR implements the following changes:

Library

Documentation

  • Add documentation for auto-adjust-text-size.

Demo

  • Add an option to demonstrate auto-adjust-text-size on demo page.

Implementation

Instead of simply returning from the font recalc function, I went with a slightly different approach that takes care of conditionally registering/removing resize listener for the chart based on the prop's value.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #30 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          115       121    +6     
  Branches        24        28    +4     
=========================================
+ Hits           115       121    +6     
Impacted Files Coverage Δ
src/components/Donut.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08dfbbf...aaf421b. Read the comment docs.

@dumptyd dumptyd merged commit f4f729d into master Mar 22, 2020
@dumptyd dumptyd deleted the disable-font-recalc branch September 19, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a prop to disable font size recalculation
1 participant