New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Calculator with Pipelines #873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit only makes changes to how the tests access the returned calculations.
Now that we're doing all our modifications on the Order & not an array of data, we don't need two "things" passed into the pipeline. This means we can simplify the pipleline by only passing in the Order object.
For extendability reasons
…imple-commerce into refactor-calculator
Released as part of v5.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the "order calculator" to use Laravel Pipelines, allowing for logic to be better split up rather than being in one big class.
All of the existing tests are passing. I've just had to change how information is fetched from the calculations as we're no longer passing around the
$data
array like we were before.The code for this PR was written almost exclusively in CLT/BFS airports on the way back from Flat Camp.✈️
Change: extending the
Calculator
Overriding the
Calculator
class was documented up until v5.x. This could have been useful if you need to do your own kinds of calculations.I don't think anyone is doing this from support requests & bug reports. However, if you are, you will need to move any custom logic into a pipeline class, like this one, then override the static
calculate
method and include your pipe class.