Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve tax calculation issues #880

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Resolve tax calculation issues #880

merged 6 commits into from
Jun 16, 2023

Conversation

duncanmcclean
Copy link
Owner

This pull request aims to resolve some tax calculation issues, many of which were introduced as part of #873 and #874.

This PR resolves the following issues:

  • Totals weren't being reset at the start of the calculation process - this caused issues when updating existing orders (eg. updating a line item quantity)
  • Standard Tax Engine: Fixed an issue where the line item total was being set to the tax calculation amount, rather than 'line item total - tax calculation amount' when price includes tax.
  • Standard Tax Engine: Fixed an issue where the tax calculation wasn't correct.

duncanmcclean and others added 6 commits June 16, 2023 12:21
@duncanmcclean
Fix line item total when price includes tax
c7958ec 
This was the calculation previous to me refactoring the calculator.
@duncanmcclean
Fix tax calculations for line items
218a5fa 
Product price: 3080
Tax rate: 10%

Previously, tax amount was: 280
Now, after fixing, it is: 308
@duncanmcclean
Reset order totals before calculating
c6ba253
@duncanmcclean
Fix wrong tax amounts in tests
57c8f87
@duncanmcclean
Also fix calculation for shipping tax
bf28c83
@duncanmcclean @github-actions
Apply Code Style changes
cd39c07
@duncanmcclean duncanmcclean merged commit 60113b9 into 5.x Jun 16, 2023
@duncanmcclean duncanmcclean deleted the fix/incorrect-tax-calculations branch June 16, 2023 12:02
@github-actions
Copy link

Released as part of v5.2.1.

@duncanmcclean duncanmcclean mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@duncanmcclean