Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping Tax #874

Merged
merged 9 commits into from May 27, 2023
Merged

Shipping Tax #874

merged 9 commits into from May 27, 2023

Conversation

duncanmcclean
Copy link
Owner

@duncanmcclean duncanmcclean commented May 27, 2023

This pull request closes #856 by allowing for tax to be applied to shipping amounts. This was only made possible by changes to the calculator in #873.

By default, calculating tax for shipping methods is disabled (in both the Basic & Standard tax engines), however you may choose to enable them:

Basic Tax Engine:

To enable, you may simply flick the toggle in your Simple Commerce config:

// config/simple-commerce.php

'tax_engine_config' => [
    // ...
    'shipping_taxes' => true,
],

Then, the tax rate you set for all other products will be applied to shipping too.

Standard Tax Engine:

  1. Upon upgrade, you'll find a new 'Default - Shipping' tax category
  2. Configure tax zones & tax rates associated with the newly created category
  3. Shipping taxes will be based on the rates entered

To Do

  • Clean up documentation
  • Resolve failing test

@duncanmcclean duncanmcclean marked this pull request as ready for review May 27, 2023 11:36
@duncanmcclean duncanmcclean merged commit 82db1b7 into 5.x May 27, 2023
@duncanmcclean duncanmcclean deleted the shipping-tax branch May 27, 2023 11:42
@github-actions
Copy link

Released as part of v5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shipping rate doesn't include tax when tax is configured to be included in prices
1 participant