Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #102

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Improve logging #102

merged 4 commits into from
Jun 13, 2022

Conversation

duncanmmacleod
Copy link
Owner

This PR improves the debug logging for Sessions, mainly by using nullcontext to ensure that existing connections aren't closed twice when nested.

@duncanmmacleod duncanmmacleod added this to the 0.5.2 milestone Jun 7, 2022
@duncanmmacleod duncanmmacleod self-assigned this Jun 7, 2022
@duncanmmacleod duncanmmacleod added ecp-get-cert Related to the ecp-get-cert tool ciecplib.sessions Related to the ciecplib.sessions module ciecplib.requests Related to the ciecplib.requests module ciecplib.logging Related to the ciecplib.logging module labels Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #102 (f8ac000) into main (1a6d4eb) will increase coverage by 0.72%.
The diff coverage is 86.48%.

❗ Current head f8ac000 differs from pull request most recent head de6592f. Consider uploading reports for the commit de6592f to get more accurate results

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   88.09%   88.81%   +0.72%     
==========================================
  Files          30       31       +1     
  Lines        1050     1073      +23     
==========================================
+ Hits          925      953      +28     
+ Misses        125      120       -5     
Flag Coverage Δ
Linux 88.81% <86.48%> (+0.72%) ⬆️
Windows 88.03% <86.48%> (+0.83%) ⬆️
macOS 88.81% <86.48%> (+0.72%) ⬆️
python3.10 87.88% <72.97%> (+0.26%) ⬆️
python3.6 88.39% <86.48%> (+0.75%) ⬆️
python3.7 87.91% <72.97%> (+0.27%) ⬆️
python3.8 88.16% <72.97%> (+0.25%) ⬆️
python3.9 88.16% <72.97%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ciecplib/__init__.py 100.00% <ø> (ø)
ciecplib/tool/ecp_get_cert.py 57.40% <0.00%> (+2.05%) ⬆️
ciecplib/requests.py 89.18% <77.77%> (+15.27%) ⬆️
ciecplib/kerberos.py 100.00% <100.00%> (ø)
ciecplib/logging.py 100.00% <100.00%> (ø)
ciecplib/sessions.py 92.59% <100.00%> (+4.13%) ⬆️
ciecplib/tests/test_requests.py 100.00% <100.00%> (ø)
ciecplib/tests/test_kerberos.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a6d4eb...de6592f. Read the comment docs.

@duncanmmacleod duncanmmacleod added the ciecplib.kerberos Related to the ciecplib.kerberos module label Jun 9, 2022
@duncanmmacleod duncanmmacleod force-pushed the improve-logging branch 2 times, most recently from 45527f6 to de6592f Compare June 13, 2022 14:37
@duncanmmacleod
Copy link
Owner Author

The reduction in coverage will be addressed by #106.

@duncanmmacleod duncanmmacleod merged commit 39b206d into main Jun 13, 2022
@duncanmmacleod duncanmmacleod deleted the improve-logging branch June 13, 2022 15:20
@duncanmmacleod duncanmmacleod modified the milestones: 0.5.2, 0.6.0 Oct 19, 2022
@duncanmmacleod duncanmmacleod added the api:patch No changes to the API label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:patch No changes to the API ciecplib.kerberos Related to the ciecplib.kerberos module ciecplib.logging Related to the ciecplib.logging module ciecplib.requests Related to the ciecplib.requests module ciecplib.sessions Related to the ciecplib.sessions module ecp-get-cert Related to the ecp-get-cert tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant