-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging #102
Improve logging #102
Conversation
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 88.09% 88.81% +0.72%
==========================================
Files 30 31 +1
Lines 1050 1073 +23
==========================================
+ Hits 925 953 +28
+ Misses 125 120 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3709047
to
4bf93de
Compare
45527f6
to
de6592f
Compare
The reduction in coverage will be addressed by #106. |
This PR improves the debug logging for Sessions, mainly by using
nullcontext
to ensure that existing connections aren't closed twice when nested.