Merge pull request #48 from martinellimarco/master

Fixed a minor regression and improved documentations.
duncanthrax · Jun 5, 2019 · 2dde734 · 2dde734
2 parents 9f973f4 + 33ba7de
commit 2dde734
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -134,6 +134,7 @@ example:
   <address type='pci' domain='0x0000' bus='0x00' slot='0x11' function='0x0'/>
 </shmem>
 ```
+- Install the IVSHMEM driver from [here](https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/upstream-virtio/).
 - To make the driver use IVSHMEM, add a DWORD `HKLM\SYSTEM\CurrentControlSet\Services\Scream\Options\UseIVSHMEM`,
 with the value being the size of the device in MB (2, as recommended). Please
 note that scream will identify the device by its size, so you should only

diff --git a/Scream/minwave.cpp b/Scream/minwave.cpp
@@ -529,9 +529,9 @@ Return Value:
                         else if ((pWfx->wFormatTag == WAVE_FORMAT_EXTENSIBLE) && (pWfx->cbSize == CB_EXTENSIBLE)) {
                             WAVEFORMATEXTENSIBLE* pWfxT = (WAVEFORMATEXTENSIBLE*)pWfx;
                             // The channel mask can be greater than 0x07FF, but only in exotic configurations.
-                            // It's important that the number of channels is even, to fit in PCM_PAYLOAD_SIZE. The only known case of odd number is 6.1 surround.
+                            // It's important that the number of channels is even, to fit in PCM_PAYLOAD_SIZE. Mono is an exception.
                             // This restriction doesn't apply if IVSHMEM is used, because the packet size is dynamic there.
-                            if ((pWfx->nChannels >= 1) && (pWfx->nChannels <= 8) && (pWfxT->dwChannelMask <= 0x07FF) && (g_UseIVSHMEM || pWfx->nChannels % 2 == 0)) {
+                            if ((pWfx->nChannels >= 1) && (pWfx->nChannels <= 8) && (pWfxT->dwChannelMask <= 0x07FF) && (g_UseIVSHMEM || pWfx->nChannels == 1 || pWfx->nChannels % 2 == 0)) {
                                 ntStatus = STATUS_SUCCESS;
                             }
                         }