Modernize deps #185
Open
Modernize deps #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetom
force-pushed
the
modernize-deps
branch
from
3990a14
to
8cf2819
Compare
to make understanding upgrades more convenient.
onetom
force-pushed
the
modernize-deps
branch
from
8cf2819
to
e7908d1
Compare
dundalek
reviewed
Dec 5, 2022
There was a problem hiding this comment.
Thanks for the effort, however it seems the CI jobs are broken, it is hard to tell what is the cause given the PR is quite large. A possible approach would be to open a smaller PR first to upgrade the test containers. And then see if upgrading the version packages will not introduce breakage.
|
|
||
| "5:3" | ||
| #"/throw1\.cljc:(\d+:\d+)" | ||
| "5" |
There was a problem hiding this comment.
We lost the column information. What is the reason here?
| :exclusions [rewrite-cljs/rewrite-cljs]}} | ||
| {org.clojure/clojure | ||
| {:mvn/version "1.11.1" | ||
| :changelog "https://github.com/clojure/clojure/blob/master/changes.md"} |
There was a problem hiding this comment.
What are these changelog fields? Is that something supported by tools.deps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the Clojure version usable on modern hardware (Apply Silicon aka M1 / M2 Macs).
Since, the CLJS variant relies on the unmaintained
lumoproject, this PR doesn't try to address dependency upgrades for that.