Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ctrl+z for job control #250

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

yurenchen000
Copy link
Contributor

only tested on

  • OS:
    • ubuntu 22.04
  • terminal:
    • terminator
    • kitty
  • TERM
    • xterm-*
    • linux //scroll back maybe broken (same as vim)

@lilydjwg
Copy link

I tested your patch on Arch Linux with tmux and it worked well.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: -0.29 ⚠️

Comparison is base (c410af8) 93.85% compared to head (21a706d) 93.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   93.85%   93.57%   -0.29%     
==========================================
  Files          29       29              
  Lines        2768     2784      +16     
==========================================
+ Hits         2598     2605       +7     
- Misses        129      138       +9     
  Partials       41       41              
Impacted Files Coverage Δ
tui/keys.go 90.98% <12.50%> (-5.51%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dundee dundee merged commit 979de13 into dundee:master May 31, 2023
9 of 10 checks passed
@dundee
Copy link
Owner

dundee commented May 31, 2023

Great contribution! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants