Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use unicode block elements in size bar #255

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

dundee
Copy link
Owner

@dundee dundee commented Jun 5, 2023

config option style.use-old-size-bar added to revert back to legacy size bar

closes #254

config option `style.use-old-size-bar` added to revert back to legacy size bar
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (a51e062) 93.50% compared to head (6ee4fbc) 93.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   93.50%   93.58%   +0.08%     
==========================================
  Files          29       29              
  Lines        2786     2806      +20     
==========================================
+ Hits         2605     2626      +21     
+ Misses        140      139       -1     
  Partials       41       41              
Impacted Files Coverage Δ
cmd/gdu/app/app.go 92.14% <100.00%> (+0.16%) ⬆️
tui/format.go 100.00% <100.00%> (ø)
tui/show.go 98.50% <100.00%> (ø)
tui/tui.go 91.00% <100.00%> (+0.09%) ⬆️
tui/utils.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dundee
Copy link
Owner Author

dundee commented Jun 5, 2023

@yurenchen000 How do you like it?

old-bar new-bar

@yurenchen000
Copy link
Contributor

That's awesome ✨
I like it very much

Thank you, I appreciate it

@dundee
Copy link
Owner Author

dundee commented Jun 6, 2023

Great 🙂 I will add some more tests and then merge the PR.

@dundee dundee merged commit 689f223 into master Jun 6, 2023
10 checks passed
@dundee dundee deleted the dundee/feat/bar branch June 6, 2023 07:25
@rwahyudi
Copy link

rwahyudi commented Jun 8, 2023

@dundee - The delimiter line on RHEL6/7/8 is not showing up as line :
image

@daniejstriata
Copy link
Collaborator

daniejstriata commented Jun 9, 2023

@dundee - The delimiter line on RHEL6/7/8 is not showing up as line : image

@rwahyudi What are the details for the host you are connecting from? What is the OS, terminal application and TERM env?

@dundee
Copy link
Owner Author

dundee commented Jun 9, 2023

This is probably more about the font used in the terminal. It probably supports just some selection of unicode block elements.

@rwahyudi
Copy link

Yup! The font that I'm using does not have the complete set of Unicode elements.

I'm on Windows 10 and tested using MobaXterm & Putty.

I tried 3 different fonts before raising the issue and all of them had similar problems.
The 3 fonts I used :
Consolas
Lucida Console
Courier New

Changing the font to Dejavu Sans Mono fix the issue, but I think Courier New is the default font for Putty on Windows.

@dundee
Copy link
Owner Author

dundee commented Jun 16, 2023

Btw there is config option style.use-old-size-bar: true to use the old size bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How about higher resolution size bar ?
4 participants