Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: package gdu in docker container #313

Merged
merged 7 commits into from Feb 14, 2024
Merged

Conversation

rare-magma
Copy link
Contributor

Containerizing gdu makes it easier to use without installing it.
Please note that I haven't tested the commands in the makefile, only executed them manually in the terminal

Signed-off-by: rare-magma <rare-magma@posteo.eu>
Signed-off-by: rare-magma <rare-magma@posteo.eu>
Signed-off-by: rare-magma <rare-magma@posteo.eu>
Signed-off-by: rare-magma <rare-magma@posteo.eu>
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efa7e46) 90.16% compared to head (64db7af) 90.13%.

❗ Current head 64db7af differs from pull request most recent head 9832a7a. Consider uploading reports for the commit 9832a7a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   90.16%   90.13%   -0.03%     
==========================================
  Files          31       31              
  Lines        3345     3345              
==========================================
- Hits         3016     3015       -1     
- Misses        267      268       +1     
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dundee dundee merged commit a33d871 into dundee:master Feb 14, 2024
7 checks passed
@dundee
Copy link
Owner

dundee commented Feb 14, 2024

Nice contribution, thank you!

@rare-magma
Copy link
Contributor Author

@dundee thanks for accepting the PR and creating the automated workflow. Do you think it would make sense to add the packages section in the repo homepage so it's easy to see it?
image
example:
image

@dundee
Copy link
Owner

dundee commented Feb 15, 2024

Good point! Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants