Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Momentmodels, bindable numerical fluxes, etc #170

Merged
merged 101 commits into from Oct 7, 2019
Merged

Conversation

tobiasleibner
Copy link
Member

This is #157, transferred to a new branch to see if that fixes CI.

@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #170 into master will decrease coverage by 1.43%.
The diff coverage is 80.21%.

Impacted Files Coverage Δ
dune/gdt/local/finite-elements/lagrange.hh 76.36% <ø> (-1.28%) ⬇️
...t/test/momentmodels/entropyflux_implementations.hh 65.97% <ø> (ø)
dune/gdt/type_traits.hh 0% <ø> (ø) ⬆️
dune/gdt/local/integrands/product.hh 63.8% <ø> (+23.84%) ⬆️
dune/gdt/local/bilinear-forms/integrals.hh 85.67% <ø> (+15.75%) ⬆️
dune/gdt/spaces/interface.hh 19.46% <0%> (-2.2%) ⬇️
dune/gdt/local/functionals/integrals.hh 54.44% <0%> (-21.54%) ⬇️
dune/gdt/local/finite-elements/interfaces.hh 64.51% <0%> (+0.77%) ⬆️
dune/gdt/local/numerical-fluxes/vijayasundaram.hh 0% <0%> (-100%) ⬇️
...local/assembler/operator-fd-jacobian-assemblers.hh 0% <0%> (-62.24%) ⬇️
... and 264 more

@tobiasleibner
Copy link
Member Author

The issues from the last merge should be fixed, so this is again ready to be merged.

Copy link
Member

@ftalbrecht ftalbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a bunch of comments. In addition, we should talk about the discrete/nondiscrete operator :/

dune/gdt/discretefunction/datahandle.hh Outdated Show resolved Hide resolved
dune/gdt/interpolations/default.hh Show resolved Hide resolved
dune/gdt/interpolations/default.hh Show resolved Hide resolved
dune/gdt/interpolations/default.hh Show resolved Hide resolved
dune/gdt/interpolations/default.hh Show resolved Hide resolved
dune/gdt/spaces/hdiv/raviart-thomas.hh Outdated Show resolved Hide resolved
dune/gdt/spaces/interface.hh Outdated Show resolved Hide resolved
dune/gdt/spaces/l2/discontinuous-lagrange.hh Outdated Show resolved Hide resolved
dune/gdt/spaces/l2/finite-volume.hh Outdated Show resolved Hide resolved
dune/gdt/test/integrands/integrands_div.cc Show resolved Hide resolved
@tobiasleibner tobiasleibner force-pushed the momentmodels_etc branch 2 times, most recently from c462db2 to 50c8e04 Compare September 27, 2019 13:04
@tobiasleibner
Copy link
Member Author

@ftalbrecht, I addressed your comments and there are some new open issues now for the parts we decided to do after the merge. Please have a look at the new commits and feel free to merge this PR if you are okay with these changes.

Copy link
Member

@ftalbrecht ftalbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few virtuals seem to be still there, apart from that I am happy!

const DomainType& point_in_reference_element,
DynamicVector<F>& result,
const XT::Common::Parameter& param = {}) const
virtual void evaluate(const LocalBasisType& basis,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The virtual seems to be still there

@tobiasleibner
Copy link
Member Author

Yep, my search and replace did not take into account functions where virtual and override are on different lines. I will remove the remaining virtuals manually whenever I see them.

@tobiasleibner tobiasleibner merged commit 4bd7263 into master Oct 7, 2019
@tobiasleibner tobiasleibner deleted the momentmodels_etc branch October 7, 2019 11:34
@renefritze renefritze restored the momentmodels_etc branch November 24, 2021 14:04
@renefritze renefritze deleted the momentmodels_etc branch February 17, 2022 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants