Momentmodels, bindable numerical fluxes, etc #170
Conversation
Codecov Report
|
The issues from the last merge should be fixed, so this is again ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a bunch of comments. In addition, we should talk about the discrete/nondiscrete operator :/
c462db2
to
50c8e04
Compare
50c8e04
to
f314716
Compare
…eighbor() is false
2845cae
to
e933aa3
Compare
@ftalbrecht, I addressed your comments and there are some new open issues now for the parts we decided to do after the merge. Please have a look at the new commits and feel free to merge this PR if you are okay with these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few virtuals seem to be still there, apart from that I am happy!
const DomainType& point_in_reference_element, | ||
DynamicVector<F>& result, | ||
const XT::Common::Parameter& param = {}) const | ||
virtual void evaluate(const LocalBasisType& basis, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The virtual
seems to be still there
Yep, my search and replace did not take into account functions where |
This is #157, transferred to a new branch to see if that fixes CI.