Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zarith 1.13 release #7

Merged
merged 6 commits into from Mar 20, 2024
Merged

Conversation

hannesm
Copy link
Contributor

@hannesm hannesm commented Mar 11, 2024

fixes #5

@hannesm
Copy link
Contributor Author

hannesm commented Mar 11, 2024

Hm, the CI is failing, but from the log I can't figure out what is actually going wrong? Any clues about that?

@hannesm
Copy link
Contributor Author

hannesm commented Mar 19, 2024

debugging shows the error in zarith's configure:

+ ocamlc -custom -ccopt -L/src/_build/solo5/duniverse/Zarith/../../../install/solo5/lib/gmp/  tmp.ml -cclib -lgmp -o tmp.out
/usr/bin/ld: /src/_build/solo5/duniverse/Zarith/../../../install/solo5/lib/gmp//libgmp.so: file not recognized: file truncated
collect2: error: ld returned 1 exit status
File "tmp.ml", line 1:
Error: Error while building custom runtime system

I am now trying to revert the specific zarith commit, and go back to use $cc instead of $ocamlc. Another path may be to teach zarith to use our own (ocaml-solo5) ocamlc toolchain!?

let's take it how it is: our libgmp.so is an empty file, we're only doing statically linked builds anyways...

@hannesm
Copy link
Contributor Author

hannesm commented Mar 19, 2024

ok, this is good for review and merge once CI passes. I avoided the issue above and re-released the package.

@hannesm
Copy link
Contributor Author

hannesm commented Mar 19, 2024

CI is green \o/

@dinosaure dinosaure merged commit 797cb36 into dune-universe:main Mar 20, 2024
2 checks passed
@dinosaure
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zarith 1.13
2 participants