Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] ocp-ocamlres (0.4+dune2) #162

Merged

Conversation

NathanReb
Copy link
Member

A simple tool and library to embed files and directories inside an OCaml executables

Release updated dune port of 0.4

Release updated dune port of 0.4
@tmattio
Copy link
Contributor

tmattio commented Apr 15, 2022

LGTM, but I'm curious why you're creating a new release instead of overriding the old one?

Copy link
Contributor

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but I concur with @tmattio, that this could've been +dune since presumably nobody used the original port.

@NathanReb
Copy link
Member Author

NathanReb commented Apr 15, 2022

My rule here is that if it has been released to opam-overlays, I simply go for the re-release.

I agree it's a bit overkill here as it's unlikey anybody had time to lock it yet but as we will gain more users, we'll need to follow such rules to avoid breaking people's lockfile.

@NathanReb NathanReb merged commit 0fc9fa7 into dune-universe:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants