-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create airdrop.claims
with 38 airdrops
#2979
Conversation
airdrop_claims.all
with 25 airdropsairdrop.claims
with 25+ airdrops
airdrop.claims
with 25+ airdropsairdrop.claims
with 25 airdrops
Since this is a new sector, maybe @augustog can take a look. |
, account AS recipient | ||
, contract_address | ||
, evt_tx_hash AS tx_hash | ||
, amount/POWER(10, 18) AS quantity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to cast any of these as double for dunesql future-proofing? Many had decimal amounts (i.e. 778.79)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! All of the quantity
rows were replaced by (amount_raw
, amount_original
and amount_usd
) to be consistent with other spells, those are respectively cast as decimal(38, 0)
, double
and double
as they should be to not cause any issues with DuneSQL
sorry, more merge conflicts to resolve 😅 also -- looks like some models are maybe missing in schema file, hence the error on pre-commit hooks test? |
need to resolve some issues on why the ci test is timing out, then get a successful run as expected, then we can proceed 🙏 |
looks like it timed out on dunesql check, that should be fine. i'll let it run this last time on latest merge and then we should be good edit: trying again without other PRs at same time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we're finally all good 🤞
This reverts commit 4e4aa95.
This reverts commit 4e4aa95.
…cs#2979)" (duneanalytics#3418)" This reverts commit 478ef1d.
* create airdrop_claims.all * fix * more fixes * fix * fix * fix * fix * fix * fix * fixx * add safe * fix * refactor * fix * add galxe to dbt_project * fix * fix * cast as doubles and remove post airdrop token movements * add 13 airdrops * fix * add readme draft * estend ci timeout * change from quantity to (amount_raw, amount_original & amount_usd) * fix * fix * fix * fix * add earliest price for pre-trading claims * fix * fix * dex.prices for tokens not on coinpaprika * fix * fix * turn finished airdrops into static tables * add genie/uniswap airdrop * added gnosis, bnb and avalanche airdrops so it`s easy to work with going forward * extend ci timeout * fixes * fix * fix * fix * fix * fix * fix * fix * change ci timeout back to 1h * fox * fix * fix * fix * fix --------- Co-authored-by: jeff-dude <102681548+jeff-dude@users.noreply.github.com>
duneanalytics#3418) This reverts commit 4e4aa95.
* Revert "Revert "Create `airdrop.claims` with 38 airdrops (duneanalytics#2979)" (duneanalytics#3418)" This reverts commit 478ef1d. * added schema to all configs --------- Co-authored-by: Huang Geyang <Sukebeta@outlook.com>
Brief comments on the purpose of your changes:
Here I created a new sector
airdrop
since without standardisation, things are starting to get messy in spellbook. The goal is to have 3 main tables at the end (airdrop.claims
,airdrop.eligible
,airdrop.total_stats
):airdrop.claims
is what this PR creates, its onchain claims of airdropsairdrop.eligible
would have the eligible address lists and since the breakdown is different per airdrop, this would only contain the address and total its eligible for with the breakdown still in the sub models.airdrop.total_stats
would have 1 line per airdrop and consist of total claimable, % claimed, etcAll those depend on their blockchain dependant sub-abstractions (ie
airdrop.claims
depends onairdrop_ethereum.claims
andairdrop_optimism.claims
) in this PR. And those depend on the protocol specific tables (ielooksrare_ethereum.airdrop_claims
).This PR creates
airdrop.claims
with those airdrops included so far:General checks:
lowercase_snake_cased
Pricing checks:
coin_id
represents the ID of the coin on coinpaprika.comJoin logic:
Incremental logic: