New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clipper.exchange on Optimism #3311
Add clipper.exchange on Optimism #3311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Hosuke |
Hi @amalashkevich there may be some conflicts between branches need to be resolved. Please sync/update the branch with main manually. |
- check_dex_seed: | ||
blockchain: optimism | ||
project: clipper | ||
version: coves_v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a typo:
- check_dex_seed: | |
blockchain: optimism | |
project: clipper | |
version: coves_v1 | |
- check_dex_seed: | |
blockchain: optimism | |
project: clipper | |
version: coves1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. for the changes
Hi @Hosuke |
Hi @amalashkevich can you update the branch? We need to wait for a second reviewer for the final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks all
Brief comments on the purpose of your changes:
For Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Pricing checks:
coin_id
represents the ID of the coin on coinpaprika.comJoin logic:
Incremental logic: