Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init opensea_arbitrum.events #3324

Merged
merged 11 commits into from
Jun 5, 2023
Merged

Conversation

sohwak
Copy link
Contributor

@sohwak sohwak commented May 11, 2023

Brief comments on the purpose of your changes:

For Dune Engine V2

Init opensea_arbitrum.events for Seaport v1.0, v1.4, v1.5

I've checked that:

General checks:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased
  • if adding a new model, I edited the dbt project YAML file with new directory path for both models and seeds (if applicable)
  • if wanting to expose a model in the UI (Dune data explorer), I added a post-hook in the JINJA config to add metadata (blockchains, sector/project, name and contributor Dune usernames)

Pricing checks:

  • coin_id represents the ID of the coin on coinpaprika.com
  • all the coins are active on coinpaprika.com (please remove inactive ones)

Join logic:

  • if joining to base table (i.e. ethereum transactions or traces), I looked to make it an inner join if possible

Incremental logic:

  • I used is_incremental & not is_incremental jinja block filters on both base tables and decoded tables
    • where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to base table (i.e. ethereum transactions or traces), I applied join condition where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to prices view, I applied join condition where minute >= date_trunc("day", now() - interval '1 week')

@dune-eng
Copy link

Workflow run id 4945429441 approved.

@dune-eng
Copy link

Workflow run id 4945429440 approved.

@dune-eng
Copy link

Workflow run id 4945504699 approved.

@dune-eng
Copy link

Workflow run id 4945504697 approved.

@dune-eng
Copy link

Workflow run id 4945535832 approved.

@dune-eng
Copy link

Workflow run id 4945535837 approved.

@dune-eng
Copy link

Workflow run id 4945577445 approved.

@dune-eng
Copy link

Workflow run id 4945577446 approved.

@dune-eng
Copy link

Workflow run id 4945696387 approved.

@dune-eng
Copy link

Workflow run id 4945696394 approved.

@dune-eng
Copy link

Workflow run id 4947223065 approved.

@dune-eng
Copy link

Workflow run id 4947223060 approved.

@sohwak
Copy link
Contributor Author

sohwak commented May 11, 2023

Hi, Dune team. I think this PR works as intended. Please check this.

@Hosuke Hosuke added ready-for-review this PR development is complete, please review NFT labels May 15, 2023
@0xRobin 0xRobin self-assigned this May 16, 2023
@dune-eng
Copy link

Workflow run id 5004212422 approved.

@dune-eng
Copy link

Workflow run id 5004212420 approved.

@dune-eng
Copy link

Workflow run id 5117115132 approved.

@dune-eng
Copy link

Workflow run id 5117115131 approved.

Copy link
Collaborator

@0xRobin 0xRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@0xRobin 0xRobin removed the ready-for-review this PR development is complete, please review label May 30, 2023
@dune-eng
Copy link

Workflow run id 5121108723 approved.

@dune-eng
Copy link

Workflow run id 5121108721 approved.

@dune-eng
Copy link

Workflow run id 5134941070 approved.

@dune-eng
Copy link

Workflow run id 5134941069 approved.

@dune-eng
Copy link

Workflow run id 5134941148 approved.

@dune-eng
Copy link

Workflow run id 5134941151 approved.

@dune-eng
Copy link

dune-eng commented Jun 4, 2023

Workflow run id 5170211927 approved.

@dune-eng
Copy link

dune-eng commented Jun 4, 2023

Workflow run id 5170211928 approved.

@jeff-dude jeff-dude merged commit a16f765 into duneanalytics:main Jun 5, 2023
2 checks passed
@sohwak sohwak deleted the opensea-arbitrum branch June 19, 2023 05:00
olgafetisova pushed a commit to olgafetisova/spellbook that referenced this pull request Nov 14, 2023
* Init opensea_arbitrum tables

* fix bug

* fix bug

* fix bug

* modify seed

* moved source table definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants