Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add element nft trades polygon #3348

Merged
merged 7 commits into from
Jun 5, 2023

Conversation

henrystats
Copy link
Contributor

Brief comments on the purpose of your changes:

For Dune Engine V2

I've checked that:

General checks:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased
  • if adding a new model, I edited the dbt project YAML file with new directory path for both models and seeds (if applicable)
  • if wanting to expose a model in the UI (Dune data explorer), I added a post-hook in the JINJA config to add metadata (blockchains, sector/project, name and contributor Dune usernames)

Pricing checks:

  • coin_id represents the ID of the coin on coinpaprika.com
  • all the coins are active on coinpaprika.com (please remove inactive ones)

Join logic:

  • if joining to base table (i.e. ethereum transactions or traces), I looked to make it an inner join if possible

Incremental logic:

  • I used is_incremental & not is_incremental jinja block filters on both base tables and decoded tables
    • where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to base table (i.e. ethereum transactions or traces), I applied join condition where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to prices view, I applied join condition where minute >= date_trunc("day", now() - interval '1 week')

@dune-eng
Copy link

Workflow run id 4986562615 approved.

@dune-eng
Copy link

Workflow run id 4986562616 approved.

@dune-eng
Copy link

Workflow run id 4986753710 approved.

@dune-eng
Copy link

Workflow run id 4986753712 approved.

@sohwak
Copy link
Contributor

sohwak commented May 16, 2023

@henrystats
I came across this, and glad you're working on this. But I found this data isn't well come into Polygon. I tried to fix it with Dune team, but I couldn't.

CCed you on Discord

@0xRobin 0xRobin added ready-for-review this PR development is complete, please review NFT labels May 16, 2023
@0xRobin 0xRobin self-assigned this May 16, 2023
@0xRobin 0xRobin added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels May 30, 2023
Copy link
Collaborator

@0xRobin 0xRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @henrystats I've updated your PR to use the new NFT sector structure.
There are however duplicates in the polygon model causing tests to fail, please review them.

@0xRobin 0xRobin added WIP work in progress and removed in review Assignee is currently reviewing the PR labels May 30, 2023
@dune-eng
Copy link

Workflow run id 5123856349 approved.

@dune-eng
Copy link

Workflow run id 5123856351 approved.

@dune-eng
Copy link

Workflow run id 5123891344 approved.

@dune-eng
Copy link

Workflow run id 5123891350 approved.

@henrystats
Copy link
Contributor Author

fixed the dupes issue ser @0xRobin

@0xRobin 0xRobin added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jun 4, 2023
@0xRobin 0xRobin self-requested a review June 4, 2023 12:13
@0xRobin 0xRobin removed the ready-for-review this PR development is complete, please review label Jun 5, 2023
@jeff-dude jeff-dude merged commit 3875dab into duneanalytics:main Jun 5, 2023
2 checks passed
@henrystats henrystats deleted the element-polygon branch June 6, 2023 14:26
olgafetisova pushed a commit to olgafetisova/spellbook that referenced this pull request Nov 14, 2023
* add element nft trades polygon

* fi schema

* add uniqueness test

* test dupes

---------

Co-authored-by: 0xRob <0xRobin5@gmail.com>
Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants