-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add element nft trades polygon #3348
Conversation
Workflow run id 4986562615 approved. |
Workflow run id 4986562616 approved. |
Workflow run id 4986753710 approved. |
Workflow run id 4986753712 approved. |
@henrystats CCed you on Discord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @henrystats I've updated your PR to use the new NFT sector structure.
There are however duplicates in the polygon model causing tests to fail, please review them.
Workflow run id 5123856349 approved. |
Workflow run id 5123856351 approved. |
Workflow run id 5123891344 approved. |
Workflow run id 5123891350 approved. |
fixed the dupes issue ser @0xRobin |
* add element nft trades polygon * fi schema * add uniqueness test * test dupes --------- Co-authored-by: 0xRob <0xRobin5@gmail.com> Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com>
Brief comments on the purpose of your changes:
For Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Pricing checks:
coin_id
represents the ID of the coin on coinpaprika.comJoin logic:
Incremental logic: