-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Airswap v4 ERC20 swaps #3404
Conversation
Workflow run id 5072096530 approved. |
Workflow run id 5072096523 approved. |
hi @ivigamberdiev -- this model currently is excluded from prod due to duplicates. please see the |
in theory, should see duplicates occur in the gh action, unless changes in PR here fixed that |
Workflow run id 5073264140 approved. |
Workflow run id 5073264136 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.✅
Thank you @ivigamberdiev
Seems there is no dupes shown in dbt-test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
* Add Airswap v4 ERC20 swaps to trades * Remove 'prod_exclude' for Airswap trades --------- Co-authored-by: Huang Geyang <Sukebeta@outlook.com> Co-authored-by: jeff-dude <102681548+jeff-dude@users.noreply.github.com>
Brief comments on the purpose of your changes:
For Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Pricing checks:
coin_id
represents the ID of the coin on coinpaprika.comJoin logic:
Incremental logic: