Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product type names #3439

Merged
merged 6 commits into from
Jun 5, 2023

Conversation

guyhow
Copy link
Contributor

@guyhow guyhow commented May 29, 2023

Brief comments on the purpose of your changes:

For Dune Engine V2

I've checked that:

General checks:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased
  • if adding a new model, I edited the dbt project YAML file with new directory path for both models and seeds (if applicable)
  • if wanting to expose a model in the UI (Dune data explorer), I added a post-hook in the JINJA config to add metadata (blockchains, sector/project, name and contributor Dune usernames)

Pricing checks:

  • coin_id represents the ID of the coin on coinpaprika.com
  • all the coins are active on coinpaprika.com (please remove inactive ones)

Join logic:

  • if joining to base table (i.e. ethereum transactions or traces), I looked to make it an inner join if possible

Incremental logic:

  • I used is_incremental & not is_incremental jinja block filters on both base tables and decoded tables
    • where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to base table (i.e. ethereum transactions or traces), I applied join condition where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to prices view, I applied join condition where minute >= date_trunc("day", now() - interval '1 week')

@dune-eng
Copy link

Workflow run id 5112602079 approved.

@dune-eng
Copy link

Workflow run id 5112602080 approved.

@Hosuke Hosuke added the easy label May 30, 2023
@Hosuke Hosuke self-assigned this May 30, 2023
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @guyhow

I added an accepted_values test for field product_type.

@jeff-dude jeff-dude merged commit d312eab into duneanalytics:main Jun 5, 2023
2 checks passed
olgafetisova pushed a commit to olgafetisova/spellbook that referenced this pull request Nov 14, 2023
* Change product type names to match dune v2 naming and style.

* Capitialise the first letter of the token product name value

* Update seed with new product type name values.

* Capitialise eth slashing and sherlock product type name values

* Add accepted values test

---------

Co-authored-by: Guy Howlett <guyhowlett@Lauras-MacBook-Pro-2.local>
Co-authored-by: Huang Geyang <Sukebeta@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants