Revert "[Erc20] Adding 477 missing tokens to mainnet (#3460)" #3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 54dc425.
couralex6
approved these changes
Jun 2, 2023
|
checking on this. We should only be picking the combination of l1_token and l2_token once. So this is weird. |
15 tasks
|
Are we going to "unrevert" this? |
using the newer PRs |
olgafetisova
pushed a commit
to olgafetisova/spellbook
that referenced
this pull request
Nov 14, 2023
)" (duneanalytics#3465) This reverts commit 54dc425.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while this spell is fine, it appears additions have broken
tokens_optimism.erc20which left joins to this spell intokens_optimism_erc20_bridged_mapping. it is causing duplicates for one address:0x9bcef72be871e61ed4fbbc7630889bee758eb81dwith the symbolrETHandRETHi don't have time to debug further atm, so i'm reverting and will need someone to help out
cc @MSilb7 @chuxinh @bh2smith