Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EUROC to avalanche_c_erc20 tokens #3467

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

discochuck
Copy link
Contributor

Eurocoin (EUC) is an open-sourced, decentralized digital cryptocurrency that functions on a community-based standard.

Brief comments on the purpose of your changes:

For Dune Engine V2

I've checked that:

General checks:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased
  • if adding a new model, I edited the dbt project YAML file with new directory path for both models and seeds (if applicable)
  • if wanting to expose a model in the UI (Dune data explorer), I added a post-hook in the JINJA config to add metadata (blockchains, sector/project, name and contributor Dune usernames)

Pricing checks:

  • coin_id represents the ID of the coin on coinpaprika.com
  • all the coins are active on coinpaprika.com (please remove inactive ones)

Join logic:

  • if joining to base table (i.e. ethereum transactions or traces), I looked to make it an inner join if possible

Incremental logic:

  • I used is_incremental & not is_incremental jinja block filters on both base tables and decoded tables
    • where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to base table (i.e. ethereum transactions or traces), I applied join condition where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to prices view, I applied join condition where minute >= date_trunc("day", now() - interval '1 week')

Eurocoin (EUC) is an open-sourced, decentralized digital cryptocurrency that functions on a community-based standard.
@dune-eng
Copy link

dune-eng commented Jun 3, 2023

Workflow run id 5161532102 approved.

@dune-eng
Copy link

dune-eng commented Jun 3, 2023

Workflow run id 5161532103 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @discochuck

@@ -215,4 +215,5 @@ FROM (VALUES
,('0xAEC8318a9a59bAEb39861d10ff6C7f7bf1F96C57','agEUR',18)
,('0x8901cB2e82CC95c01e42206F8d1F417FE53e7Af0','YFX',18)
,('0xDE5ed76E7c05eC5e4572CfC88d1ACEA165109E44','DEUS',18)
,('0xC891EB4cbdEFf6e073e859e987815Ed1505c2ACD','EUROC',6)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-dude jeff-dude merged commit ca50f3e into duneanalytics:main Jun 6, 2023
2 checks passed
olgafetisova pushed a commit to olgafetisova/spellbook that referenced this pull request Nov 14, 2023
Eurocoin (EUC) is an open-sourced, decentralized digital cryptocurrency that functions on a community-based standard.

Co-authored-by: Huang Geyang <Sukebeta@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants