Dex Aggregator Migration - #1 - Lifi #4054
Conversation
|
Workflow run id 5838376322 approved. |
|
Workflow run id 5838376381 approved. |
|
Workflow run id 5838462152 approved. |
|
Workflow run id 5838462302 approved. |
|
Workflow run id 5838510283 approved. |
|
Workflow run id 5838510387 approved. |
|
Workflow run id 5840578360 approved. |
|
Workflow run id 5840578413 approved. |
|
Workflow run id 5840604879 approved. |
|
Workflow run id 5840604948 approved. |
|
Workflow run id 5840662723 approved. |
|
Workflow run id 5840662743 approved. |
|
Workflow run id 5843829939 approved. |
|
Workflow run id 5843829992 approved. |
henrystats
changed the title
|
Workflow run id 5843855123 approved. |
|
Workflow run id 5843855120 approved. |
There was a problem hiding this comment.
LGTM.✅
Thank you @henrystats
- Partition by block_month ✅
- Tests and seeds migrated ✅
antonio-mendes
added
the
ready-for-review
antonio-mendes
changed the title
jeff-dude
added
in review
| CAST(dexs.token_bought_amount_raw AS UINT256) AS token_bought_amount_raw, | ||
| CAST(dexs.token_sold_amount_raw AS UINT256) AS token_sold_amount_raw, |
There was a problem hiding this comment.
these are both already uint256 at the source, we can remove the cast
There was a problem hiding this comment.
will fix, there are a couple of other changes @antonio-mendes mentioned in other models as well... If you're reviewing/merging this evening I can submit the fix for all the models since it won't take a lot of time.. actually lemme get to it now.. I was trying to complete something else but It should be good.
There was a problem hiding this comment.
cleaned up will fix other models now @jeff-dude
|
Workflow run id 5906206862 approved. |
|
Workflow run id 5906206789 approved. |
|
Workflow run id 5906209873 approved. |
|
Workflow run id 5906209943 approved. |
|
Workflow run id 5906310872 approved. |
|
Workflow run id 5906310886 approved. |
jeff-dude
added
ready-for-merging
and removed
in review
Thank you for contributing to Spellbook!
Please refer to the top of the
readmein the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.