Dex Aggregator Migration - #2 - Yield yak #4063
Conversation
|
Workflow run id 5843934042 approved. |
|
Workflow run id 5843934097 approved. |
henrystats
changed the title
antonio-mendes
added
dex
ready-for-review
antonio-mendes
changed the title
There was a problem hiding this comment.
Thanks for the work here @henrystats ! I've left a few notes on updates to keep things neat
| CAST(dexs.token_bought_amount_raw AS DECIMAL(38,0)) AS token_bought_amount_raw, | ||
| CAST(dexs.token_sold_amount_raw AS DECIMAL(38,0)) AS token_sold_amount_raw, | ||
| CAST(dexs.token_bought_amount_raw AS UINT256) AS token_bought_amount_raw, | ||
| CAST(dexs.token_sold_amount_raw AS UINT256) AS token_sold_amount_raw, |
There was a problem hiding this comment.
These fields are already UINT256 in the decoded table so no need to cast
There was a problem hiding this comment.
oke ser... will remove cast.
| dexs.trace_address, | ||
| dexs.evt_index | ||
| FROM dexs | ||
| INNER JOIN {{ source('avalanche_c', 'transactions') }} tx | ||
| ON tx.hash = dexs.tx_hash | ||
| {% if not is_incremental() %} | ||
| AND tx.block_time >= '{{project_start_date}}' | ||
| AND tx.block_time >= DATE '{{project_start_date}}' |
There was a problem hiding this comment.
I think this might work as is but we should swap DATE here for TIMESTAMP to match the block_time data type
| @@ -89,19 +91,18 @@ LEFT JOIN {{ source('prices', 'usd') }} p_bought | |||
| AND p_bought.contract_address = dexs.token_bought_address | |||
| AND p_bought.blockchain = 'avalanche_c' | |||
| {% if not is_incremental() %} | |||
| AND p_bought.minute >= '{{project_start_date}}' | |||
| AND p_bought.minute >= DATE '{{project_start_date}}' | |||
| {% endif %} | ||
| LEFT JOIN {{ source('prices', 'usd') }} p_sold | ||
| ON p_sold.minute = date_trunc('minute', dexs.block_time) | ||
| AND p_sold.contract_address = dexs.token_sold_address | ||
| AND p_sold.blockchain = 'avalanche_c' | ||
| {% if not is_incremental() %} | ||
| AND p_sold.minute >= '{{project_start_date}}' | ||
| AND p_sold.minute >= DATE '{{project_start_date}}' |
| tx.from as tx_from, | ||
| tx.to AS tx_to, | ||
| tx."from" as tx_from, | ||
| tx."to" AS tx_to, |
There was a problem hiding this comment.
Here you don't need the "" since to isn't a special keyword
|
Thank you ser, I'll make these changes across all the other pr's as well! |
|
Workflow run id 5906189792 approved. |
|
Workflow run id 5906189599 approved. |
|
Workflow run id 5906192581 approved. |
|
Workflow run id 5906192603 approved. |
|
already made the changes here too ser @jeff-dude |
jeff-dude
added
ready-for-merging
and removed
ready-for-review
Thank you for contributing to Spellbook!
Please refer to the top of the
readmein the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.