Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate NFT opensea models #4083

Merged
merged 41 commits into from
Aug 23, 2023
Merged

Migrate NFT opensea models #4083

merged 41 commits into from
Aug 23, 2023

Conversation

0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Aug 15, 2023

Migrate NFT opensea models

@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@0xRobin
Copy link
Collaborator Author

0xRobin commented Aug 15, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 15, 2023
@github-actions
@0xRobin has signed the CLA in #4083
a5263a1
@0xRobin
Copy link
Collaborator Author

0xRobin commented Aug 15, 2023

recheck

@0xRobin
Copy link
Collaborator Author

0xRobin commented Aug 15, 2023

all non-seaport models passing ✔️

@0xRobin 0xRobin marked this pull request as ready for review August 22, 2023 13:04
@0xRobin 0xRobin requested a review from jeff-dude August 22, 2023 13:04
@0xRobin
Copy link
Collaborator Author

0xRobin commented Aug 22, 2023 •
edited

cc: @hildobby and @sohwak this PR translates the opensea models to DuneSQL and puts both seaport models (v3 and v4) in a macro so the logic is consistent across chains.

@jeff-dude jeff-dude self-assigned this Aug 22, 2023
@jeff-dude jeff-dude added the in review Assignee is currently reviewing the PR label Aug 22, 2023
jeff-dude
jeff-dude reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments below, otherwise looking great 🚀

models/opensea/ethereum/opensea_v4_ethereum_events.sql Outdated Show resolved Hide resolved
models/opensea/ethereum/opensea_v4_ethereum_events.sql Outdated Show resolved Hide resolved
macros/models/_sector/nft/platforms/seaport_v3_trades.sql Outdated Show resolved Hide resolved
@jeff-dude jeff-dude removed the in review Assignee is currently reviewing the PR label Aug 23, 2023
@jeff-dude jeff-dude merged commit de7302f into duneanalytics:main Aug 23, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
@0xRobin 0xRobin deleted the migrate-nft-opensea branch May 20, 2024 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
dune team created by dune team NFT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xRobin @jeff-dude