Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tigris Options Trade & Enrich Models - Ready for review #4099

Merged
merged 35 commits into from
Aug 23, 2023

Conversation

henrystats
Copy link
Contributor

Thank you for contributing to Spellbook!

Please refer to the top of the readme in the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.

@dune-eng
Copy link

Workflow run id 5882629459 approved.

@dune-eng
Copy link

Workflow run id 5882629694 approved.

@dune-eng
Copy link

Workflow run id 5882971633 approved.

@dune-eng
Copy link

Workflow run id 5882971858 approved.

@dune-eng
Copy link

Workflow run id 5883194516 approved.

@dune-eng
Copy link

Workflow run id 5883194555 approved.

@dune-eng
Copy link

Workflow run id 5883461627 approved.

@dune-eng
Copy link

Workflow run id 5883461709 approved.

@dune-eng
Copy link

Workflow run id 5883497470 approved.

@dune-eng
Copy link

Workflow run id 5883497613 approved.

@dune-eng
Copy link

Workflow run id 5886090890 approved.

@dune-eng
Copy link

Workflow run id 5886090801 approved.

@dune-eng
Copy link

Workflow run id 5886144246 approved.

@dune-eng
Copy link

Workflow run id 5886144373 approved.

@dune-eng
Copy link

Workflow run id 5886146530 approved.

@dune-eng
Copy link

Workflow run id 5886146529 approved.

@dune-eng
Copy link

Workflow run id 5886356198 approved.

@dune-eng
Copy link

Workflow run id 5886356271 approved.

@dune-eng
Copy link

Workflow run id 5892880081 approved.

@dune-eng
Copy link

Workflow run id 5914298988 approved.

@dune-eng
Copy link

Workflow run id 5914299066 approved.

@henrystats henrystats changed the title Add Tigris Options Trade - WIP Add Tigris Options Trade & Enrich Models - Ready for review Aug 20, 2023
@henrystats
Copy link
Contributor Author

@jeff-dude, there's a tigris_trade & tigris_perpetual_trades model... Both have the same date somewhat but there are couple of different columns since I wanted to add tigris trades to the perpetual trades model...

The tigris.trades model is still needed on dune.com because of these columns that get renamed / repurposed in the perpetual model..

This is now ready for review.. adding seeds as well and tested the data against what is currently there.

@dune-eng
Copy link

Workflow run id 5914396330 approved.

@dune-eng
Copy link

Workflow run id 5914396368 approved.

@Hosuke Hosuke added the ready-for-review this PR development is complete, please review label Aug 21, 2023
@dune-eng
Copy link

Workflow run id 5931873573 approved.

@dune-eng
Copy link

Workflow run id 5931873645 approved.

@dune-eng
Copy link

Workflow run id 5933910771 approved.

@dune-eng
Copy link

Workflow run id 5933910810 approved.

@dune-eng
Copy link

Workflow run id 5934008968 approved.

@dune-eng
Copy link

Workflow run id 5934009068 approved.

@dune-eng
Copy link

Workflow run id 5944194944 approved.

@dune-eng
Copy link

Workflow run id 5944195044 approved.

@jeff-dude jeff-dude self-assigned this Aug 23, 2023
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Aug 23, 2023
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🔥

@jeff-dude jeff-dude removed the in review Assignee is currently reviewing the PR label Aug 23, 2023
@jeff-dude jeff-dude merged commit f533922 into duneanalytics:main Aug 23, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
@henrystats henrystats deleted the add-tigris-options branch August 24, 2023 01:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants