Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add PNDC for eth price tracking #4152

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

skiinginjeans
Copy link
Contributor

@skiinginjeans skiinginjeans commented Aug 24, 2023

Adds PNDC for price tracking per documentation here

Would like to add price tracking to https://dune.com/skisinjeans/pond-coin

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dune-eng
Copy link

Workflow run id 5958362534 approved.

@dune-eng
Copy link

Workflow run id 5958362583 approved.

@dune-eng
Copy link

Workflow run id 5958362594 approved.

@skiinginjeans
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor Author

@skiinginjeans skiinginjeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recheck

@dune-eng
Copy link

Workflow run id 5958473042 approved.

@dune-eng
Copy link

Workflow run id 5958473040 approved.

@dune-eng
Copy link

Workflow run id 5958473039 approved.

@dune-eng
Copy link

Workflow run id 5958533308 approved.

@dune-eng
Copy link

Workflow run id 5958533401 approved.

@dune-eng
Copy link

Workflow run id 5958533396 approved.

@jeff-dude jeff-dude self-assigned this Aug 24, 2023
@jeff-dude jeff-dude added the in review Assignee is currently reviewing the PR label Aug 24, 2023
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for the delay -- this looks good to me

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Aug 24, 2023
@jeff-dude jeff-dude merged commit 920020d into duneanalytics:main Aug 24, 2023
4 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Aug 24, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Dune Contributor:

GitPOAP: 2023 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
@skiinginjeans skiinginjeans deleted the add-pndc-prices branch August 25, 2023 02:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants