contracts_optimism_contract_creator_list Additional Edits
#4322
Conversation
|
Workflow run id 6166196666 approved. |
|
Workflow run id 6166196742 approved. |
|
Workflow run id 6166279425 approved. |
|
Workflow run id 6166279527 approved. |
models/contracts/optimism/contracts_optimism_contract_creator_address_list.sql
Outdated
Show resolved
Hide resolved
|
Workflow run id 6175314869 approved. |
|
Workflow run id 6175314948 approved. |
|
Workflow run id 6175394794 approved. |
|
Workflow run id 6175394658 approved. |
|
Workflow run id 6175634422 approved. |
|
Workflow run id 6175634520 approved. |
jeff-dude
changed the title
contracts_optimism_contract_creator_list Additional Edits
|
tagging @MSilb7 for a thumbs up 👍 |
| ,(0x645487828d5769c20365fdb8786a5e2b734d785c, 'Altitude Bridge') | ||
| ,(0x01cf911dd46f90290bf5f93d0ef34237df7df1b6, 'Hedgey Finance') | ||
| ,(0x320bcb681ce7023edfe48ade9cf5bf67a11bcd36, 'Hedgey Finance') | ||
| ,(0xf537880c505bfa7cda6c8c49d7efa53d45b52d40, 'Binance Exchange') |
There was a problem hiding this comment.
rename to 'Binance' for consistency with CEX labels
There was a problem hiding this comment.
Okay, will do that.
|
|
||
| -- Enforce consistent project name mapping to contracts_optimism_project_name_mappings.sql |
There was a problem hiding this comment.
we already handle for this in contract mapping, but could work to handle here as well.
|
|
||
| -- Enforce consistent project name mapping to contracts_optimism_project_name_mappings.sql | ||
| SELECT list.creator_address, | ||
| (CASE |
There was a problem hiding this comment.
this could likely just be a coalesce(mapping.mapped_name, list.contract_project) to simplify
There was a problem hiding this comment.
Ok, will do as requested.
|
Workflow run id 6177323881 approved. |
|
Workflow run id 6177323967 approved. |
|
Workflow run id 6181843377 approved. |
|
Workflow run id 6181843416 approved. |
|
@MSilb7 I've made all the requested changes. This PR solves the "Contract deployer mapping" task on Dework here: https://app.dework.xyz/optimism-community/main-space-35638?taskId=9906bf4d-f0ef-45bc-8bb5-f3e0444ec2a1. If this PR is approved and merged, Is there any info to add (e.g link to PR) when submitting the task on Dework as no such information is provided in the link? |
|
Workflow run id 6189627570 approved. |
|
Workflow run id 6189627706 approved. |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Dune Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
I have read the CLA Document and I hereby sign the CLA