Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Paintswap on Fantom to nft.trades #5791

Merged
merged 20 commits into from
Jun 25, 2024
Merged

Conversation

hildobby
Copy link
Collaborator

Thank you for contributing to Spellbook!

Thank you for taking the time to submit code in Spellbook. A few things to consider:

  • If you are a first-time contributor, please sign the CLA by copy & pasting exactly what the bot mentions in PR comment
  • Refer to docs section below to answer questions
  • Dune team will review submitted PRs as soon as possible

Best practices

To speed up your development process in PRs, keep these tips in mind:

  • Each commit to your feature branch will rerun CI tests (see example)
    • This includes all modified models on your branch
    • This includes all history of the data
  • Two tips for faster development iteration:
    • Ensure dbt is installed locally (refer to main readme) and run dbt compile
      • This will output raw SQL in target/ directory to copy/paste and run on Dune directly for initial query testing
    • Hardcode a WHERE filter for only ~7 days of history on large source tables, i.e. ethereum.transactions
      • This will speed up the CI tests and output results quicker -- whether that's an error or fully successful run
      • Once comfortable with small timeframe, remove filter and let full history run

Incremental model setup

  • Make sure your unique key columns are exactly the same in the model config block, schema yml file, and seed match columns (where applicable)
  • There cannot be nulls in the unique key columns
    • Be sure to double check key columns are correct or COALESCE() as needed on key column(s), otherwise the tests may fail on duplicates

🪄 Use the built CI tables for testing 🪄

Once CI completes, you can query the CI tables and errors in dune when it finishes running.

  • For example:
    • In the run initial models and test initial models, there will be a schema that looks like this: test_schema.git_dunesql_4da8bae_sudoswap_v2_base_pool_creations
    • This can be temporarily queried in Dune for ~24 hours

Leverage these tables to perform QA testing on Dune query editor -- or even full test dashboards!

Spellbook contribution docs

The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each .md file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄

Example questions to be answered:

Please navigate through the docs directory to find as much info as you can.

Note: happy to take PRs to improve the docs, let us know 🤝

@hildobby hildobby added WIP work in progress NFT labels Apr 17, 2024
@hildobby hildobby added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jun 2, 2024
@hildobby hildobby requested a review from 0xRobin June 3, 2024 14:01
Copy link
Collaborator

@0xRobin 0xRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as the current model look good, it's only missing the integration into nft_base_trades.

I'm also marking this as blocked as it'll need to be adapted when #6090 is merged (mainly just moving the new files to the new location)

@0xRobin 0xRobin added blocked ready-for-final-review and removed ready-for-review this PR development is complete, please review labels Jun 7, 2024
@0xRobin 0xRobin mentioned this pull request Jun 7, 2024
@jeff-dude jeff-dude added WIP work in progress and removed blocked ready-for-final-review labels Jun 17, 2024
@jeff-dude
Copy link
Member

removing the blocked label and adding wip
no rush though, just cleaning up the queue

@0xRobin
Copy link
Collaborator

0xRobin commented Jun 18, 2024

@hildobby should be good once you move the changes to the new nft subproject.

@hildobby hildobby added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jun 19, 2024
@0xRobin 0xRobin added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jun 20, 2024
@jeff-dude jeff-dude assigned jeff-dude and unassigned 0xRobin Jun 24, 2024
@jeff-dude jeff-dude merged commit 7dfa548 into duneanalytics:main Jun 25, 2024
2 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants