Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily spellbook account abstractions #6036

Merged
merged 8 commits into from
May 30, 2024
Merged

Conversation

aalan3
Copy link
Contributor

@aalan3 aalan3 commented May 30, 2024

This moves account abstractions which has a pretty clean lineage

@aalan3 aalan3 requested a review from jeff-dude May 30, 2024 11:57
@aalan3
Copy link
Contributor Author

aalan3 commented May 30, 2024

@jeff-dude in the last two commits I've updated these models to use the incremental predicate, figured it's a good time to do it since these will run in a full refresh now

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice clean one. will be a good example to link for communications / reference

@jeff-dude jeff-dude self-assigned this May 30, 2024
@aalan3 aalan3 merged commit 788df05 into main May 30, 2024
3 checks passed
@aalan3 aalan3 deleted the daily-spellbook-account-abstractions branch May 30, 2024 17:35
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants