Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex.trades: add DefiPlaza #614

Merged
merged 4 commits into from
Dec 10, 2021
Merged

Conversation

Echolon166
Copy link
Contributor

Added DEX DefiPlaza to dex.trades table as requested in #588.
Results of the DefiPlaza query can be checked at the dune_user_generated.defiplaza table.

I've checked that:

  • the query produces the intended results
  • the folder name matches the schema name
  • the schema name exists in Dune
  • views are prefixed with view_, functions with fn_.
  • the filename matches the defined view, table or function and ends with .sql
  • each file has only one view, table or function defined
  • column names are lowercase_snake_cased

Copy link
Contributor

@masquot masquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Echolon166.

Overall this looks like a great job. Very useful that you added the link to dune_user_generated for testing.

Checks:

Can you please implement following changes:

  1. add usd_amount for trades involving ETH. How to can be found in the changes in the file here: ethereum/dex/trades/insert_mooniswap.sql using the link https://github.com/duneanalytics/abstractions/pull/556/files
  2. Can you change the version from 'NULL` to '1'?

@Echolon166
Copy link
Contributor Author

Thank you @Echolon166.

Overall this looks like a great job. Very useful that you added the link to dune_user_generated for testing.

Checks:

Can you please implement following changes:

  1. add usd_amount for trades involving ETH. How to can be found in the changes in the file here: ethereum/dex/trades/insert_mooniswap.sql using the link https://github.com/duneanalytics/abstractions/pull/556/files
  2. Can you change the version from 'NULL` to '1'?

Thanks for the feedback! I've made the changes that you requested.

Copy link
Contributor

@masquot masquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Echolon166.

@masquot masquot merged commit 8598ebb into duneanalytics:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants