Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: markdown editor commands #1586

Merged
merged 26 commits into from
Jan 4, 2022

Conversation

maxb2
Copy link
Member

@maxb2 maxb2 commented Dec 5, 2021

This adds more buttons in the markdown note editor.
Closes #440

TODO:

  • Refactor new functions. There's a lot of repeated code right now.
  • Roll Macro template. Very simple. Selected text becomes the chat message.
  • Lists
    • Unordered
    • Ordered
    • Checkbox
      • Render check boxes.
      • Make check boxes togglable when rendered Would require editing note. Maybe in the future.
    • Convert between kinds of lists.
  • Text tools
    • Cycle header levels
    • Paragraph It would just add a newline, so I don't see the point...
    • Strikethrough
    • Code
    • Quote. Could use a better icon.
    • Table

@n1ru4l
Copy link
Member

n1ru4l commented Dec 18, 2021

image

The quote looks a bit weird, I think we can style it better.

Also, the checkbox styling can be improved, to look more similar to github:

  • asdasdadsd

Toggling it it would be a great feature!

src/feather-icons.tsx Outdated Show resolved Hide resolved
@n1ru4l n1ru4l added this to the v1.17.0 milestone Dec 18, 2021
@maxb2
Copy link
Member Author

maxb2 commented Dec 19, 2021

Also, the checkbox styling can be improved, to look more similar to github:

I changed it to a chakra Checkbox. I liked it better and it should give us more consistent styling.

The quote looks a bit weird, I think we can style it better.

I agree.
I updated the quote style to be the same as ScrollableList.ListItemButton.
I have no strong feelings for any of the styling, so feel free to make any suggestions/changes.
Here is a sample of what everything looks like:

Screenshot from 2021-12-19 20-29-00

Toggling it it would be a great feature!

I'd love to have them be togglable and update the markdown note accordingly (Github issues does this), but I'm not sure how to implement it.

@maxb2 maxb2 marked this pull request as ready for review December 20, 2021 02:35
@maxb2
Copy link
Member Author

maxb2 commented Dec 20, 2021

@n1ru4l this is ready for review. It can be merged as-is unless you really want to be able to convert between list types (requires some more regexing). Added converting between list types.

@n1ru4l n1ru4l merged commit b37c53a into dungeon-revealer:master Jan 4, 2022
@n1ru4l n1ru4l mentioned this pull request Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more markdown editor commands
2 participants